Show loading spinner when loading data #1645
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
|
|
@ahtrotta if we can hit a few of the most important cases in this PR, then we can always follow-on with other cases later. We don't have to get all of them right away. |
I'm having a bit of troubling getting things to behave the way I want to. |
ahtrotta
force-pushed
the
feat/show-loading-spinner
branch
from
727af3b to
0c1579c
Compare
ahtrotta
force-pushed
the
feat/show-loading-spinner
branch
2 times, most recently
from
8c230ee to
967585a
Compare
ahtrotta
force-pushed
the
feat/show-loading-spinner
branch
from
967585a to
c6ee367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1641